Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

engine: open external domain links in a new tab #729

Closed
shcheklein opened this issue Oct 23, 2019 · 4 comments
Closed

engine: open external domain links in a new tab #729

shcheklein opened this issue Oct 23, 2019 · 4 comments
Assignees
Labels
A: docs Area: user documentation (gatsby-theme-iterative) p1-important Active priorities to deal within next sprints type: enhancement Something is not clear, small updates, improvement suggestions website: eng-doc DEPRECATED JS engine for /doc

Comments

@shcheklein
Copy link
Member

Use a special symbol :after: the link that go to an external resource.

Also, I think, we should use a new tab to open them.

@shcheklein shcheklein added A: docs Area: user documentation (gatsby-theme-iterative) website: eng-doc DEPRECATED JS engine for /doc type: enhancement Something is not clear, small updates, improvement suggestions labels Oct 23, 2019
@jorgeorpinel
Copy link
Contributor

Why not just use HTML? <a href=... target="_blank"> ?

@shcheklein
Copy link
Member Author

@jorgeorpinel yep, that can be exactly the solution we are looking for 👍 . The only thing left is to integrate it into engine - generate different link with or w/o target blank.

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Oct 24, 2019

I mean we can just enter HTML into the .md files. Or do you want to extend the MD language like [external](link)_blank ?

Another option would be to open links that go outside the website domain (dvc.org) in a new tab by default and let the user Ctrl/Cmd+click the other ones when they want a new tab.

@shcheklein
Copy link
Member Author

Another option would be to open links that go outside the website domain (dvc.org) in a new tab by default

Yep. And I think the engine can detect those and put _blank automatically.

@jorgeorpinel jorgeorpinel changed the title mark external links and open them in a new tab engine: open external domain links in a new tab Oct 24, 2019
@shcheklein shcheklein added the p1-important Active priorities to deal within next sprints label Oct 24, 2019
@iAdramelk iAdramelk self-assigned this Nov 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) p1-important Active priorities to deal within next sprints type: enhancement Something is not clear, small updates, improvement suggestions website: eng-doc DEPRECATED JS engine for /doc
Projects
None yet
Development

No branches or pull requests

3 participants