site closes when clicking a link from the hamburger menu

[skshetry]

How to reproduce

1. Open https://dvc.org using "Open in a new tab" in the context menu from your phone (or, in a responsive mode from console). Please don't type, just use that earlier link.
2. Open hamburger menu and click on either "Doc" or "Blog".

Expected

The page opens correctly.

Actual

The site just closes.

---

This happens because we are calling the window.close() in the HamburgerMenuIcon. I am not sure why it happens on a newly opened tab only (somewhere we are opening a new window based on that?).

dvc.org/src/components/HamburgerMenu/index.tsx

Lines 43 to 49 in f08efbf

	const handleItemClick = useCallback(
	item => (): void => {
	close()
	logEvent('hamburger', item)
	},
	[]
	)

This also adds ugly warnings to the console:

Scripts may close only the windows that were opened by them.

[shcheklein]

I can't reproduce it on Mac (Chrome in a responsive mode)/iPhone, but can confirm warnings in the console. @skshetry what browser do you you use?

[skshetry]

@shcheklein, did you use the "Open in a new tab" option for the above link?

EDIT: Sorry, looks like I didn't write the repro precisely. Now fixed.

[julieg18]

I noticed the warnings while updating the hamburger menu and updated the code to stop using the close() method. @skshetry, can you confirm that the bug is gone?

[skshetry]

Can confirm that it's fixed, and I don't see an error in the console either. Thanks, @julieg18. Closing ...