Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

syntax highlighting don't always seem to work #2215

Closed
skshetry opened this issue Feb 18, 2021 · 3 comments · Fixed by #2461
Closed

syntax highlighting don't always seem to work #2215

skshetry opened this issue Feb 18, 2021 · 3 comments · Fixed by #2461
Labels
good first issue Good for newcomers help wanted Contributors especially welcome p2-nice-to-have Less of a priority at the moment. We don't usually deal with this immediately. 🐛 type: bug Something isn't working. website: eng-doc DEPRECATED JS engine for /doc

Comments

@skshetry
Copy link
Member

skshetry commented Feb 18, 2021 •
edited
Loading

When working on #2208, I had to indent or de-indent to make syntax highlighting work for stage:add.

See: #2208 (comment)

Maybe it's the issue with the subcommand?
@skshetry skshetry added 🐛 type: bug Something isn't working. website: eng-doc DEPRECATED JS engine for /doc labels Feb 18, 2021
@shcheklein shcheklein added p2-nice-to-have Less of a priority at the moment. We don't usually deal with this immediately. good first issue Good for newcomers help wanted Contributors especially welcome labels Feb 18, 2021
@jorgeorpinel
Copy link
Contributor

Hey @skshetry is #1509 basically part of this one? 🙂

@jorgeorpinel jorgeorpinel mentioned this issue May 10, 2021
Open
1 task
@skshetry
Copy link
Member Author

@jorgeorpinel, this is about syntax highlighting in the Usage. If you ordered them in a different way or indented them in a different way, highlighting would just fail.

See #2208 (comment) and #2208 (comment).

@jorgeorpinel jorgeorpinel mentioned this issue May 10, 2021
Merged
@jorgeorpinel
Copy link
Contributor

OK. It looks like it's no longer happening. Please approve #2461 which will close this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers help wanted Contributors especially welcome p2-nice-to-have Less of a priority at the moment. We don't usually deal with this immediately. 🐛 type: bug Something isn't working. website: eng-doc DEPRECATED JS engine for /doc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ref: remove extra space iterative/dvc.org
3 participants
@jorgeorpinel @shcheklein @skshetry