Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

document stage:add #2134

Closed
skshetry opened this issue Feb 1, 2021 · 3 comments · Fixed by #2208
Closed

document stage:add #2134

skshetry opened this issue Feb 1, 2021 · 3 comments · Fixed by #2208
Assignees
@skshetry
Labels
A: docs Area: user documentation (gatsby-theme-iterative) p1-important Active priorities to deal within next sprints type: enhancement Something is not clear, small updates, improvement suggestions

Comments

@skshetry
Copy link
Member

skshetry commented Feb 1, 2021

A few questions regarding documentation:

  1. How should we approach documenting dvc stage add? Duplicate most of the stuffs?
  2. Should we remove dvc run or duplicate contents?
  3. How about adding a deprecation warning in the docs for dvc run?

Related: iterative/dvc#5350
@skshetry skshetry self-assigned this Feb 1, 2021
@skshetry skshetry mentioned this issue Feb 1, 2021
Merged
2 tasks
@shcheklein
Copy link
Member

shcheklein commented Feb 1, 2021 •
edited
Loading

I would keep for now both + note in the dvc stages add that it's available since 2.0

after the release, let's get rid of dvc run (and hide it in DVC itself) + + set redirect

@jorgeorpinel
Copy link
Contributor

jorgeorpinel commented Feb 1, 2021 •
edited
Loading

Yeah both for now and I can worry about phasing out run later. Let's just make a separate issue for that please. I can add both to the #2026 epic for tracking.

Just please confirm stage add is officially part of the 2.0 release (I don't see it in iterative/dvc#5367). Or maybe it's part of what "Run" refers to? cc @dberenbaum

@dberenbaum
Copy link
Contributor

@jorgeorpinel Good callout! It was hidden under low-level issues in iterative/dvc#5367, but it's now a separate checklist item.

@jorgeorpinel jorgeorpinel mentioned this issue Feb 2, 2021
Closed
12 tasks
@shcheklein shcheklein added A: docs Area: user documentation (gatsby-theme-iterative) type: enhancement Something is not clear, small updates, improvement suggestions p1-important Active priorities to deal within next sprints labels Feb 5, 2021
@skshetry skshetry mentioned this issue Feb 17, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@skshetry skshetry

Labels
A: docs Area: user documentation (gatsby-theme-iterative) p1-important Active priorities to deal within next sprints type: enhancement Something is not clear, small updates, improvement suggestions
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

document stage:add iterative/dvc.org
4 participants
@jorgeorpinel @dberenbaum @shcheklein @skshetry