Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code snippets in documentation not available on Github #198

Closed
richardxy opened this issue Mar 7, 2019 · 8 comments
Closed

code snippets in documentation not available on Github #198

richardxy opened this issue Mar 7, 2019 · 8 comments
Labels
A: docs Area: user documentation (gatsby-theme-iterative) type: enhancement Something is not clear, small updates, improvement suggestions

Comments

@richardxy
Copy link

DVC documentation contains many examples that refer to some code snippets, such as
dvc run \ -d prepare.py -d data.xml \ -o data.tsv -o data-test.tsv \ python prepare.py data.xml

But the file prepare.py can't be found on its Github repo. It would be very helpful for users to understand how the code snippets were written so that can be used in 'dvc run'.

Hope all the "*.py" files or other code examples would be available in Git repo. Thanks for the great work!

Richard

@robogeek
Copy link
Contributor

robogeek commented Mar 7, 2019

I am currently going through the DVC commands and updating the documentation. Thank you for the feedback.

Generally speaking for now think of these as examples of what can be done, rather than precisely replicatable things.

I certainly get that you want replicatable examples, and will keep this in mind.

@richardxy
Copy link
Author

Great! Thank you very much!

@shcheklein
Copy link
Member

@richardxy could, you give a little bit more context ... which part of the documentation you are referring to in this issue?

@richardxy
Copy link
Author

I said it as a general impression for all parts of the documentation (particularly in "dvc run" part, I guess). When a .py file is referred in an example of command, but without seeing the py file, a person may not understand how such a script should be written.

@richardxy
Copy link
Author

btw, I really like the tutorial https://dvc.org/doc/tutorial/define-ml-pipeline, which has the code downloadable from S3. Even so, it would be still nice to be able to read the code files on Github without downloading and unzipping the code package.

@shcheklein
Copy link
Member

@richardxy would be great if you could take a look at this command reference https://dvc.org/doc/commands-reference/checkout . We've made example for it runnable and available on Github. Let me know if you understand the doc, is it easy enough to reproduce, any feedback. Thanks!

@shcheklein shcheklein changed the title Code snippets in documentation not available on Github code snippets in documentation not available on Github Mar 25, 2019
@shcheklein shcheklein added type: enhancement Something is not clear, small updates, improvement suggestions A: docs Area: user documentation (gatsby-theme-iterative) labels Mar 25, 2019
@jorgeorpinel
Copy link
Contributor

I think we can close this issue @shcheklein ? We don't intend to have exact reproducible examples in all docs, just in some cmd ref examples, how-tos, and tutorials.

@shcheklein
Copy link
Member

@jorgeorpinel sure! feel free to close this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: docs Area: user documentation (gatsby-theme-iterative) type: enhancement Something is not clear, small updates, improvement suggestions
Projects
None yet
Development

No branches or pull requests

4 participants