Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

banner breaks positions for other elements #1592

Closed
shcheklein opened this issue Jul 18, 2020 · 1 comment · Fixed by #1606
Closed

banner breaks positions for other elements #1592

shcheklein opened this issue Jul 18, 2020 · 1 comment · Fixed by #1606
Assignees
Labels
A: website Area: website p1-important Active priorities to deal within next sprints 🐛 type: bug Something isn't working.

Comments

@shcheklein
Copy link
Member

After we introduced the banner we broke a few things:

Screen Shot 2020-07-18 at 11 30 23 AM

Screen Shot 2020-07-18 at 11 31 47 AM

@shcheklein shcheklein added A: website Area: website 🐛 type: bug Something isn't working. p1-important Active priorities to deal within next sprints labels Jul 18, 2020
@rogermparent
Copy link
Contributor

I'm almost done with a fix for this, mostly revolving around making the placeholder grow and shrink while considering the extra height the banner adds.

I originally wanted to move the hamburger icon into the header so it could be vertically centered with position: absolute, but then found due to z-index issues we would have to sacrifice the "moving button lines" effect that requires one element to be the button in both the header and overlay menu. While it's a trade-off I'd take personally, I decided to opt for keeping all existing functionality by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: website Area: website p1-important Active priorities to deal within next sprints 🐛 type: bug Something isn't working.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants