Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link-check: trim exclusions #1184

Closed
casperdcl opened this issue Apr 25, 2020 · 5 comments · Fixed by #1189
Closed

link-check: trim exclusions #1184

casperdcl opened this issue Apr 25, 2020 · 5 comments · Fixed by #1189
Assignees
Labels
A: website Area: website type: enhancement Something is not clear, small updates, improvement suggestions

Comments

@casperdcl
Copy link
Contributor

The exclusions list (scripts/exclude-links.txt) may have links that no longer exists in the codebase. Should check for this (CI and maybe pre-commit).

@casperdcl casperdcl added the type: enhancement Something is not clear, small updates, improvement suggestions label Apr 25, 2020
@casperdcl casperdcl self-assigned this Apr 25, 2020
@casperdcl
Copy link
Contributor Author

seem to be no longer needed:

  http://localhost:3000/
  http://ogp.me/ns
  https://blog.$
  https://dvc.org/img/<filename>.gif
  https://dvc.org/uploads/images/2020-02-10/image.png
  https://example.com/path/to/data
  https://remote.dvc.org/dataset-registry/a3/04af...
  https://s3-us-east-2.amazonaws.com/dvc-s3-repo/

@shcheklein shcheklein added the A: website Area: website label Apr 25, 2020
@jorgeorpinel
Copy link
Contributor

We need a script to check the link checker script's exclusion list 😆

@jorgeorpinel
Copy link
Contributor

localhost:3000

It's localhost:8000 now.

@shcheklein
Copy link
Member

Alos, let's exclude all JS test file automatically. That will simplify the list.

@casperdcl
Copy link
Contributor Author

That's a lot more to exclude then. #1189 should catch everything on CI :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A: website Area: website type: enhancement Something is not clear, small updates, improvement suggestions
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants