Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

analytics: should we strip queries? #1179

Closed
shcheklein opened this issue Apr 22, 2020 · 3 comments · Fixed by #3117
Closed

analytics: should we strip queries? #1179

shcheklein opened this issue Apr 22, 2020 · 3 comments · Fixed by #3117
Labels
p1-important Active priorities to deal within next sprints status: research Writing concrete steps for the issue 🐛 type: bug Something isn't working.

Comments

@shcheklein
Copy link
Member

shcheklein commented Apr 22, 2020 •
edited
Loading

dvc.org/blog/a-public-reddit-dataset

should be probably the same as

dvc.org/blog/a-public-reddit-dataset?fbcid=aassdfsdfsdf

(Need to check if it's a good practice or not)
@shcheklein shcheklein added 🐛 type: bug Something isn't working. A: website Area: website p1-important Active priorities to deal within next sprints labels Apr 22, 2020
@weekly-digest weekly-digest bot mentioned this issue Apr 26, 2020
Closed
@shcheklein shcheklein added the status: research Writing concrete steps for the issue label May 7, 2020
@shcheklein shcheklein changed the title analytics: we should strip queries analytics: we should strip queries? May 20, 2020
@jorgeorpinel jorgeorpinel removed the A: website Area: website label May 9, 2021
@jorgeorpinel
Copy link
Contributor

Hi. What's the bug in this ticket? Thanks

@jorgeorpinel jorgeorpinel added the website: eng-blog DEPRECATED JS engine for /blog label May 9, 2021
@shcheklein
Copy link
Member Author

Check that on GA we track pages with and w/o query strings properly

@shcheklein shcheklein removed the website: eng-blog DEPRECATED JS engine for /blog label May 9, 2021
@jorgeorpinel jorgeorpinel changed the title analytics: we should strip queries? analytics: should we strip queries? May 10, 2021
@julieg18 julieg18 mentioned this issue Dec 21, 2021
Merged
@julieg18
Copy link
Contributor

Looking at other sites' analytics, the queries are almost never tracked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p1-important Active priorities to deal within next sprints status: research Writing concrete steps for the issue 🐛 type: bug Something isn't working.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Replace Google Analytics with Plausible iterative/dvc.org
3 participants
@jorgeorpinel @shcheklein @julieg18