Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

blog social share buttons do not work properly #1178

Closed
shcheklein opened this issue Apr 22, 2020 · 1 comment · Fixed by #1180
Closed

blog social share buttons do not work properly #1178

shcheklein opened this issue Apr 22, 2020 · 1 comment · Fixed by #1180
Labels
A: website Area: website p0-critical Affects users in a bad way at the moment 🐛 type: bug Something isn't working. website: eng-blog DEPRECATED JS engine for /blog

Comments

@shcheklein
Copy link
Member

Go to the latest blog post and try to share on FB or Twitter.

(I wonder if we can automate certain tests?)
@shcheklein shcheklein added 🐛 type: bug Something isn't working. A: website Area: website p0-critical Affects users in a bad way at the moment website: eng-blog DEPRECATED JS engine for /blog labels Apr 22, 2020
@rogermparent
Copy link
Contributor

I see the links have a part pointing to undefined, an oversight on my end porting over Models. I think it's just a quick fix involving wiring up data with the new schema- I'll get on it!

@rogermparent rogermparent mentioned this issue Apr 22, 2020
Merged
@weekly-digest weekly-digest bot mentioned this issue Apr 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A: website Area: website p0-critical Affects users in a bad way at the moment 🐛 type: bug Something isn't working. website: eng-blog DEPRECATED JS engine for /blog
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix share buttons by importing slug via GraphQL rogermparent/dvc.org
2 participants
@shcheklein @rogermparent