Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate ask_* options #12

Open
daavoo opened this issue Oct 13, 2022 · 2 comments
Open

Deprecate ask_* options #12

daavoo opened this issue Oct 13, 2022 · 2 comments

Comments

@daavoo
Copy link
Contributor

daavoo commented Oct 13, 2022

Though, another thing to note is that ask_* options are a bit of a legacy thing coming from paramiko's limitations, and asyncssh might be raising proper exceptions that would allow us to distinguish when we need to ask password or a passphrase. If you could confirm that, maybe we can just make ask_password and password obsolete and not add new options at all.

Originally posted by @efiop in #3 (comment)

@pmrowla
Copy link
Contributor

pmrowla commented Jul 25, 2023

This can be done by implementing the interactive methods in an asyncssh client subclass, see the scmrepo/dulwich implementation: iterative/scmrepo#255 (comment)

@pmrowla
Copy link
Contributor

pmrowla commented Feb 20, 2024

#52 implements the interactive methods required for 2fa with sshd ChallengeResponseAuthentication /KbdInteractiveAuthentication but is not a complete enough implementation to deprecate the current password/passphrase prompts entirely

This would need testing with more sshd configs in the future before it's probably safe to drop the ask_* options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants