Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert remaining console.log and console.error calls to logger calls #710

Closed
0x2b3bfa0 opened this issue Sep 9, 2021 · 1 comment · Fixed by #744 or #731
Closed

Convert remaining console.log and console.error calls to logger calls #710

0x2b3bfa0 opened this issue Sep 9, 2021 · 1 comment · Fixed by #744 or #731
Assignees
@0x2b3bfa0
Labels
technical-debt Refactoring, linting & tidying

Comments

@0x2b3bfa0
Copy link
Member

...and update runner.go to match the JSON schema.

See also

May depend on
@0x2b3bfa0 0x2b3bfa0 mentioned this issue Sep 9, 2021
Merged
@0x2b3bfa0 0x2b3bfa0 added the technical-debt Refactoring, linting & tidying label Sep 10, 2021
This was linked to pull requests Sep 24, 2021
Use Winston whenever possible and log to stderr #744
Merged
Fix runner status log reporting #731
Merged
@0x2b3bfa0 0x2b3bfa0 self-assigned this Sep 24, 2021
@0x2b3bfa0
Copy link
Member Author

Addressed with #744 and #731; the remaining console.log calls are at the command–line interface level, and we should agree on a default behavior for stdout versus stderr and when to use the logger.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0x2b3bfa0 0x2b3bfa0

Labels
technical-debt Refactoring, linting & tidying
Projects
None yet
Milestone
No milestone
1 participant
@0x2b3bfa0