From 3dbf98b227656c1c74d6a3ed9fdbd861ee5ad279 Mon Sep 17 00:00:00 2001 From: Casper da Costa-Luis Date: Fri, 30 Apr 2021 12:00:13 +0100 Subject: [PATCH] docs: `repo_token` => `REPO_TOKEN` --- .github/workflows/checkbot.yml | 19 +++++++------------ README.md | 10 +++++----- bin/cml-pr.js | 2 +- 3 files changed, 13 insertions(+), 18 deletions(-) diff --git a/.github/workflows/checkbot.yml b/.github/workflows/checkbot.yml index ddd2dbd0e..7112a4a7c 100644 --- a/.github/workflows/checkbot.yml +++ b/.github/workflows/checkbot.yml @@ -1,23 +1,17 @@ name: checkbot - on: issue_comment: types: [created] - -env: - repo_token: ${{ secrets.TEST_GITHUB_TOKEN }} - jobs: # check that CML container builds properly build-container: if: contains(github.event.comment.body, '/tests') runs-on: [ubuntu-18.04] - steps: - uses: actions/checkout@v2 - - name: Build test image and publish - run: | + - name: Build test image and publish + run: | echo "${{ secrets.DOCKERHUB_PASSWORD }}" | docker login -u ${{ secrets.DOCKERHUB_USERNAME }} --password-stdin docker build -t dvcorg/cml -f ./docker/Dockerfile . @@ -26,7 +20,7 @@ jobs: docker tag dvcorg/cml dvcorg/cml-test docker push dvcorg/cml-test docker run --name runner --rm \ - -e "repo_token=$repo_token" \ + -e "REPO_TOKEN=${{ secrets.TEST_GITHUB_TOKEN }}" \ -e "RUNNER_REPO=https://github.com/${GITHUB_REPOSITORY}" \ -e "RUNNER_LABELS=cml-docker" \ -e "RUNNER_IDLE_TIMEOUT=10" \ @@ -44,7 +38,7 @@ jobs: - uses: hashicorp/setup-terraform@v1 with: terraform_version: 0.14.3 - + - uses: r-lib/actions/setup-r@master - uses: actions/setup-python@v2 @@ -54,11 +48,12 @@ jobs: - name: "CML test" env: AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} - AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} + AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} AZURE_CLIENT_ID: ${{ secrets.AZURE_CLIENT_ID }} AZURE_CLIENT_SECRET: ${{ secrets.AZURE_CLIENT_SECRET }} AZURE_SUBSCRIPTION_ID: ${{ secrets.AZURE_SUBSCRIPTION_ID }} AZURE_TENANT_ID: ${{ secrets.AZURE_TENANT_ID }} + REPO_TOKEN: ${{ secrets.TEST_GITHUB_TOKEN }} run: | echo 'Check container!' > report.md vl2svg assets/vega-lite.json | cml-publish --md >> report.md @@ -142,7 +137,7 @@ jobs: }).then( (pr) => { console.log(`::set-output name=COMMAND::${process.env.COMMAND}`) }) - + - name: chatactions run: | npm ci diff --git a/README.md b/README.md index c3e71c1a2..63ffe7be6 100644 --- a/README.md +++ b/README.md @@ -85,7 +85,7 @@ jobs: python train.py - name: Write CML report env: - repo_token: ${{ secrets.GITHUB_TOKEN }} + REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | # Post reports as comments in GitHub PRs cat results.txt >> report.md @@ -174,7 +174,7 @@ jobs: - uses: iterative/setup-cml@v1 - name: Train model env: - repo_token: ${{ secrets.GITHUB_TOKEN }} + REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }} run: | pip install -r requirements.txt python train.py @@ -238,7 +238,7 @@ jobs: - uses: actions/checkout@v2 - name: Train model env: - repo_token: ${{ secrets.GITHUB_TOKEN }} + REPO_TOKEN: ${{ secrets.GITHUB_TOKEN }} AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} run: | @@ -391,7 +391,7 @@ jobs: - uses: actions/checkout@v2 - name: Deploy runner on EC2 env: - repo_token: ${{ secrets.PERSONAL_ACCESS_TOKEN }} + REPO_TOKEN: ${{ secrets.PERSONAL_ACCESS_TOKEN }} AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }} AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }} run: | @@ -408,7 +408,7 @@ jobs: - uses: actions/checkout@v2 - name: Train model env: - repo_token: ${{ secrets.PERSONAL_ACCESS_TOKEN }} + REPO_TOKEN: ${{ secrets.PERSONAL_ACCESS_TOKEN }} run: | pip install -r requirements.txt python train.py diff --git a/bin/cml-pr.js b/bin/cml-pr.js index 04c4121f9..dcde81bbe 100644 --- a/bin/cml-pr.js +++ b/bin/cml-pr.js @@ -27,7 +27,7 @@ const opts = decamelize( .default('token') .describe( 'token', - 'Personal access token to be used. If not specified in extracted from ENV repo_token.' + 'Personal access token to be used. If not specified in extracted from ENV REPO_TOKEN.' ) .default('driver') .choices('driver', ['github', 'gitlab'])