Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move iteration logic to tasks #970

Closed
2 tasks
kalantar opened this issue Aug 16, 2021 · 1 comment
Closed
2 tasks

Move iteration logic to tasks #970

kalantar opened this issue Aug 16, 2021 · 1 comment
Assignees
Labels
area/tasks Iter8 tasks kind/enhancement New feature or request

Comments

@kalantar
Copy link
Member

kalantar commented Aug 16, 2021

Is your feature request related to a problem? Please describe the problem.
Today iter8 has built in logic to read and modify traffic weights. However, if another mechanism such as helm or gitops is used, the user must use loop tasks and modify the experiment to use loops.

Describe the feature/solution you'd like
Replace the iter8 logic with tasks that mirror those used for gitops and/or helm. The approach to read/set weights is then the same for all approaches. This is related to elimination of Spec.VersionInfo (issue #953).

Tasks to look something like:

# this task will update the current weight distribution in experiment status
# by getting the actual weights from cluster
- task: clusterops/get-weights
  with:
    versionInfo: <list of weight Obj refs -- just like we would normally provide>
# this task requires clusterops/get-weighs to be specified earlier in the action pipeline, 
# it will reuse versionInfo from there.
- task: clusterops/set-weights # re-uses params from clusterops/get-weights

Will this feature/solution bring new benefits for Iter8 users? What are they?
Common approach to writing experiment for different assumptions.

Does this issue require a design doc/discussion? If there is a link to the design document/discussions, please provide it below.
Use this issue.

How will this feature be tested?

  • Modify existing test cases; create new ones in handler

How will this feature be documented?

  • Reference documentation updated; handler documentation updated.

Additional Context
This was originally documented as part of issue #941 which is now closed.

@kalantar kalantar added kind/enhancement New feature or request area/controller area/tasks Iter8 tasks labels Aug 16, 2021
@kalantar kalantar self-assigned this Aug 16, 2021
@kalantar
Copy link
Member Author

Perhaps it is better to have just one method? get-and-set-weights?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/tasks Iter8 tasks kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants