Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "Template" from URLTemplate and HeaderTemplates #930

Closed
2 tasks
kalantar opened this issue Aug 4, 2021 · 2 comments
Closed
2 tasks

Remove "Template" from URLTemplate and HeaderTemplates #930

kalantar opened this issue Aug 4, 2021 · 2 comments
Labels
area/analytics Metrics, statistical estimation, and bandit algorithms for traffic shifting kind/enhancement New feature or request

Comments

@kalantar
Copy link
Member

kalantar commented Aug 4, 2021

Is your feature request related to a problem? Please describe the problem.
Purpose is to make the names "nicer". Yes, they are templates in that they can have parameters. However, I would prefer simpler names URL and Headers.

Describe the feature/solution you'd like
Rename URLTemplate to URL and HeaderTemplates to `Headers.

Will this feature/solution bring new benefits for Iter8 users? What are they?
Maybe easier to understand. Shorter.

Will this feature/solution bring new benefits for Iter8 developers? What are they?
No

Does this issue require a design doc/discussion? If there is a link to the design document/discussions, please provide it below.
Do so here.

How will this feature be tested?

  • Existing (modified) test cases should work

How will this feature be documented?

  • Update reference documentation

Additional context
Suggestion is being made because changes are breaking and we have changes for Experiment as well. Might as well make more breaking changes at the same time.
@kalantar kalantar added kind/enhancement New feature or request area/controller area/analytics Metrics, statistical estimation, and bandit algorithms for traffic shifting labels Aug 4, 2021
@sriumcp
Copy link
Member

sriumcp commented Aug 4, 2021

SGTM.

@sriumcp
Copy link
Member

sriumcp commented Aug 6, 2021

This issue is now superceded by #934

@sriumcp sriumcp removed the v2beta1 label Aug 6, 2021
@kalantar kalantar mentioned this issue Aug 6, 2021
Closed
2 tasks
@sriumcp sriumcp added the v2beta1 label Aug 8, 2021
@kalantar kalantar mentioned this issue Aug 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/analytics Metrics, statistical estimation, and bandit algorithms for traffic shifting kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kalantar @sriumcp