Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal: modify metrics endpoints to make more similar #1620

Closed
Tracked by #1600
kalantar opened this issue Sep 1, 2023 · 1 comment · Fixed by #1629
Closed
Tracked by #1600

Proposal: modify metrics endpoints to make more similar #1620

kalantar opened this issue Sep 1, 2023 · 1 comment · Fixed by #1629
Assignees

Comments

@kalantar
Copy link
Member

kalantar commented Sep 1, 2023

To define data sources we have the following:

  • HTTP:
    • URL: http://iter8.default:8080/httpDashboard
    • query string: namespace=ns&experiment=test_name
  • gRPC:
    • URL: http://iter8.default:8080/grpcDashboard
    • query string: namespace=ns&experiment=test_name
  • A/B/n:
    • URL: http://iter8.default:8080/metrics
    • query string: application=ns%2Fapp

I wondered if we wanted to regularize this:

  • For A/B/n use abnDashboard instead of metrics as the endpoint
  • For A/B/n change structure of query string to be namespace=ns&application=app
  • change experiement to test or performance_test
  • Not sure how to make the second parameter the same; but there is no real need to
@kalantar
Copy link
Member Author

kalantar commented Sep 1, 2023

@sriumcp @Alan-Cha any comments?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants