General improvements to opsu! to match upstream game (osu!)

[chong601]

I have assigned myself to this issue (no ETA on when it can be done for now)
Checklist:

• Split updateAndRender to use org.lwjgl.Display.update() and org.lwjgl.Display.sync(FPS) to ensure use of offscreen buffer to remove dependency of high fps (superseded from Allow unlimited FPS to partially fix the jitter issue #40) (UPDATE: game choppy has been fixed, marking this as completed for now, but the development is still underway)
• Attempt to match the gameplay logic with osu! as closely as possible
• Fix scoring issue with opsu! displaying more score than osu! (screenshots will be added later for comparison)
• Remove dependency to FPS completely for all animations in opsu! (related to checklist 1)
• Allow usage of skin.ini to allow more skin customizations (focuses more on skin versions, currently in progress)

Unrelated to osu! features
Package Java Runtime Environment with opsu! to allow running on machines without JRE (scrapped because of non-portability issues, requiring three separate builds)

Any other osu! related things (that I can't think of for now) that is missing in opsu! , please post here! (I will try to make it as long I have the time and ability to do it, currently getting used to Maven goals and LWJGL APIs)

Things that I will not do (due to certain reasons)

• Online capability

Things that I will not do (because of ability issues)

• Implement DirectX (sounds like a herculean task for a non-Windows runtime)

@itdelatrisu: can you put me to the assignee and (optional) set milestone to 1.0 maybe?

[Jackall4BDN]

And here i am, back again!
Now that i have played it a bit, i gotta say, good clone considering how (compared) little time has went into its development.
BUT two things are a major pain for me right now:
-The spinners are treated way to different difficulty-wise to actually do them on higher difficulties
-Audio-Offset-Callibration is REALLY wierd when it comes to precision, i gotta set it up to about -160 ms to get it fit the notes and it still seems to vary from song to song, while in normal osu (or every other musicgame i play) i gotta set it to -50ms tops and just one time and it would stick

[FenekAlfa]

Attempt to match the gameplay logic with osu! as closely as possible

If this means autofail for some maps, removing custom AR/CS/etc. and locking K1&M1/K2&M2 together then it's a terrible idea. IMO the biggest advantage of opsu! is NOT being osu!.

[chong601]

If this means autofail for some maps, removing custom AR/CS/etc. and locking K1&M1/K2&M2 together then it's a terrible idea. IMO the biggest advantage of opsu! is NOT being osu!.

don't worry, none of the abovementioned will be happening
(to be honest, i do want to close this since i don't have enough expertise to do all of those D:)

[Lemmmy]

Audio offset bug being worked on in #78.
Slider bug has been noticed #67.

[itdelatrisu]

Fix scoring issue with opsu! displaying more score than osu! (screenshots will be added later for comparison)

Do you have any examples? Otherwise, I'll close this since the other things you mentioned are complete or aren't really "issues". I don't think it makes sense to package JRE with this, either.

[chong601]

osu! score:

opsu! score:

kinda busy with real life so unable to update them D:

[itdelatrisu]

Yeah, no problem -- thanks for taking the time to post that. Any idea what might be causing this? x.x

[chong601]

my rough guess is probably the formula for total score isn't correct (just not quite sure where)

[fluddokt]

Its the Difficulty Multiplier in the score formula.
You can try my replayTest branch, its gets pretty close for some beatmaps.
However it might screw up your opsu_scores.db after running it.

[itdelatrisu]

Yeah, that's what I've been trying to figure out. After looking at your changes, though, it looks like I was really far off... anyway, I'll commit the few updates I've made based on the osu! wiki (all lies, as you've noticed too XD), but I don't really know where to go from here.

Honestly, I don't think it's worth our time figuring out osu!'s formula if they won't bother releasing it and it's as complicated as you think. Also, nice to see you're still around. :P