test: throw Error objects instead of literals

test-tls-econnreset and test-http-response-status-message throw literals instead of Error objects. Use common.fail() which throws an AssertionError. PR-URL: nodejs#11168 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Teddy Katz <[email protected]> Reviewed-By: Colin Ihrig <[email protected]> Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Roman Reiss <[email protected]> Reviewed-By: Sakthipriyan Vairamani <[email protected]>
italoacasas · Feb 9, 2017 · 1f1ee78 · 1f1ee78
1 parent 3ce763f
commit 1f1ee78
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/test/parallel/test-http-response-status-message.js b/test/parallel/test-http-response-status-message.js
@@ -1,5 +1,5 @@
 'use strict';
-require('../common');
+const common = require('../common');
 const assert = require('assert');
 const http = require('http');
 const net = require('net');
@@ -23,7 +23,7 @@ testCases.findByPath = function(path) {
     return testCase.path === path;
   });
   if (matching.length === 0) {
-    throw 'failed to find test case with path ' + path;
+    common.fail(`failed to find test case with path ${path}`);
   }
   return matching[0];
 };

diff --git a/test/parallel/test-tls-econnreset.js b/test/parallel/test-tls-econnreset.js
@@ -49,8 +49,8 @@ const ca = [ cert, cacert ];
 let clientError = null;
 let connectError = null;
 
-const server = tls.createServer({ ca: ca, cert: cert, key: key }, (conn) => {
-  throw 'unreachable';
+const server = tls.createServer({ ca: ca, cert: cert, key: key }, () => {
+  common.fail('should be unreachable');
 }).on('tlsClientError', function(err, conn) {
   assert(!clientError && conn);
   clientError = err;