Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi-File-Input Limits broken #224

Closed
darenegade opened this issue Mar 16, 2023 · 2 comments · Fixed by #1155
Closed

Multi-File-Input Limits broken #224

darenegade opened this issue Mar 16, 2023 · 2 comments · Fixed by #1155
Labels
bug Something isn't working digiwf-apps good first issue Good for newcomers refinement

Comments

@darenegade
Copy link
Member

Describe the bug
One can Upload 19 Files as the limit of the Input is 10

Additional: It would be nice to make this configurable via form

To Reproduce
Steps to reproduce the behavior:

  1. Go to Form with Multi-File-Input
  2. Add 9 Files
  3. Add 10 Files

Expected behavior
Limit is hard at 10

Additional context
Just blogs the function to Add
https://github.com/it-at-m/digiwf-core/blob/dev/digiwf-apps/packages/components/digiwf-multi-file-input/src/components/DwfMultiFileInput.vue#L110

@darenegade darenegade added bug Something isn't working digiwf-apps good first issue Good for newcomers refinement labels Mar 16, 2023
@lmoesle
Copy link
Contributor

lmoesle commented Jul 20, 2023

Additional: It would be nice to make this configurable via form

It's a bit confusing that the issue says the upload limit should be set to 10 and additionally make it configurable.

@darenegade
Copy link
Member Author

There are two topics:

First the Bug: If we have a Limit, we should stick to it

Second: The Limit should be configurable, but that may not is Part of this Issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working digiwf-apps good first issue Good for newcomers refinement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants