Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app_message_name not unique #1068

Closed
1 task
simonhir opened this issue Dec 1, 2023 · 3 comments
Closed
1 task

app_message_name not unique #1068

simonhir opened this issue Dec 1, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@simonhir
Copy link
Member

simonhir commented Dec 1, 2023

In the camunda-connector the app_message_name is used to map the message to the correlating process step and parse the payload back into the process.
Problem here is that the attribute is not unique with genericEvent in the element templates which can lead to a error when a process runs two integrations calls in parallel. In real use cases that is very unrealistic but it would be a good idea to fix that anyway.

It may also make sense to use app_type_name and app_integration_name (see #958) instead of app_message_name for the resolution.

Possible solutions

  1. make app_message_name unique
  2. use app_type_name and app_integration_name

Acceptance criteria

  • The mapping from a integration response to a process step is always unique
@simonhir simonhir added the bug Something isn't working label Dec 1, 2023
@simonhir
Copy link
Member Author

simonhir commented Dec 1, 2023

@lmoesle was meinst du dazu?

@lmoesle
Copy link
Contributor

lmoesle commented Dec 1, 2023

Die Integrationen werden in einer Call Activity aufgerufen. Da wird dann ein eigener Subprozess erstellt für das Streaming Template, an den auch die Message der Integration korreliert wird. Also müsste der Prozess schon unique sein.

@simonhir
Copy link
Member Author

simonhir commented Dec 4, 2023

Is no bug. See above comment

@simonhir simonhir closed this as completed Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants