From 1b77249f9a9bf28550e3dd10a47fbc043865f169 Mon Sep 17 00:00:00 2001
From: Simon Zambrovski <simon.zambrovski@holisticon.de>
Date: Thu, 12 Oct 2023 10:08:16 +0200
Subject: [PATCH] add aria labels, fix #715 (#809)

---
 .../src/components/UI/AppPaginationFooter.vue              | 2 ++
 .../digiwf-tasklist/src/components/common/SearchField.vue  | 7 ++++---
 .../digiwf-tasklist/src/components/form/BaseLdapInput.vue  | 1 +
 .../src/components/process/ProcessDefinitionItem.vue       | 4 +++-
 .../src/components/process/ProcessInstanceItem.vue         | 4 +++-
 .../digiwf-tasklist/src/components/task/GroupTaskItem.vue  | 2 +-
 .../src/components/task/TaskFollowUpDialog.vue             | 1 +
 .../apps/digiwf-tasklist/src/components/task/TaskItem.vue  | 4 +++-
 8 files changed, 18 insertions(+), 7 deletions(-)

diff --git a/digiwf-apps/packages/apps/digiwf-tasklist/src/components/UI/AppPaginationFooter.vue b/digiwf-apps/packages/apps/digiwf-tasklist/src/components/UI/AppPaginationFooter.vue
index 786d3e3fb9..209a97cf40 100644
--- a/digiwf-apps/packages/apps/digiwf-tasklist/src/components/UI/AppPaginationFooter.vue
+++ b/digiwf-apps/packages/apps/digiwf-tasklist/src/components/UI/AppPaginationFooter.vue
@@ -48,6 +48,7 @@
         <template #activator="{ on, attrs }">
           <v-btn
             :disabled="lastPageButtonDisabled"
+            aria-label="Vorherige Seite"
             small
             text
             color="primary"
@@ -70,6 +71,7 @@
             small
             text
             :disabled="nextPageButtonDisabled"
+            aria-label="Nächste Seite"
             color="primary"
             class="ml-1"
             v-bind="attrs"
diff --git a/digiwf-apps/packages/apps/digiwf-tasklist/src/components/common/SearchField.vue b/digiwf-apps/packages/apps/digiwf-tasklist/src/components/common/SearchField.vue
index 9998fcb410..a6a8fd8bed 100644
--- a/digiwf-apps/packages/apps/digiwf-tasklist/src/components/common/SearchField.vue
+++ b/digiwf-apps/packages/apps/digiwf-tasklist/src/components/common/SearchField.vue
@@ -11,6 +11,7 @@
     outlined
     hide-details
     :items="persistentFilters?.map((f) => f.filterString) || []"
+    aria-label="Aufgaben durchsuchen"
     label="Aufgaben durchsuchen"
     clearable
     style="max-width: 500px"
@@ -26,7 +27,7 @@
           class="v-icon"
           @click="deletePersistentFilter()"
         >
-          <v-icon color="primary">
+          <v-icon color="primary" aria-label="Filter löschen" role="img" aria-hidden="false">
             mdi-star
           </v-icon>
         </v-btn>
@@ -37,12 +38,12 @@
           class="v-icon"
           @click="savePersistentFilter()"
         >
-          <v-icon color="primary">
+          <v-icon color="primary" aria-label="Filter speichern" role="img" aria-hidden="false">
             mdi-star-outline
           </v-icon>
         </v-btn>
       </div>
-      <v-icon class="ml-2">
+      <v-icon class="ml-2" aria-label="Aufgaben durchsuchen" role="img" aria-hidden="false">
         mdi-magnify
       </v-icon>
     </template>
diff --git a/digiwf-apps/packages/apps/digiwf-tasklist/src/components/form/BaseLdapInput.vue b/digiwf-apps/packages/apps/digiwf-tasklist/src/components/form/BaseLdapInput.vue
index f003a45fb4..6cbf79fe69 100644
--- a/digiwf-apps/packages/apps/digiwf-tasklist/src/components/form/BaseLdapInput.vue
+++ b/digiwf-apps/packages/apps/digiwf-tasklist/src/components/form/BaseLdapInput.vue
@@ -15,6 +15,7 @@
     item-value="lhmObjectId"
     item-text="lhmObjectId"
     placeholder="Benutzer suchen..."
+    aria-label="Benutzer suchen"
     @input="input"
   >
     <template #selection="data">
diff --git a/digiwf-apps/packages/apps/digiwf-tasklist/src/components/process/ProcessDefinitionItem.vue b/digiwf-apps/packages/apps/digiwf-tasklist/src/components/process/ProcessDefinitionItem.vue
index 194cd7f98b..03b4abd316 100644
--- a/digiwf-apps/packages/apps/digiwf-tasklist/src/components/process/ProcessDefinitionItem.vue
+++ b/digiwf-apps/packages/apps/digiwf-tasklist/src/components/process/ProcessDefinitionItem.vue
@@ -42,8 +42,10 @@
               data-cy="dropdown-menu-button"
               @click="(event) => { event.preventDefault()}"
               v-on.prevent="on"
+              aria-label="Aktionen für den Vorgang"
+              aria-hidden="false"
             >
-              <v-icon>mdi-dots-vertical</v-icon>
+              <v-icon aria-label="Aktionen für den Vorgang" role="img" aria-hidden="false">mdi-dots-vertical</v-icon>
             </v-btn>
           </template>
           <v-list>
diff --git a/digiwf-apps/packages/apps/digiwf-tasklist/src/components/process/ProcessInstanceItem.vue b/digiwf-apps/packages/apps/digiwf-tasklist/src/components/process/ProcessInstanceItem.vue
index 4d93aeb5c6..e8fe88c0e5 100644
--- a/digiwf-apps/packages/apps/digiwf-tasklist/src/components/process/ProcessInstanceItem.vue
+++ b/digiwf-apps/packages/apps/digiwf-tasklist/src/components/process/ProcessInstanceItem.vue
@@ -55,8 +55,10 @@
               v-bind="attrs"
               @click="(event) => { event.preventDefault()}"
               v-on.prevent="on"
+              aria-label="Aktionen für den Vorgang"
+              aria-hidden="false"
             >
-              <v-icon>mdi-dots-vertical</v-icon>
+              <v-icon aria-label="Aktionen für den Vorgang" role="img" aria-hidden="false">mdi-dots-vertical</v-icon>
             </v-btn>
           </template>
           <v-list>
diff --git a/digiwf-apps/packages/apps/digiwf-tasklist/src/components/task/GroupTaskItem.vue b/digiwf-apps/packages/apps/digiwf-tasklist/src/components/task/GroupTaskItem.vue
index 3816a1a751..8cdd89837b 100644
--- a/digiwf-apps/packages/apps/digiwf-tasklist/src/components/task/GroupTaskItem.vue
+++ b/digiwf-apps/packages/apps/digiwf-tasklist/src/components/task/GroupTaskItem.vue
@@ -86,7 +86,7 @@
             @click="(event) => { event.preventDefault()}"
             v-on.prevent="on"
           >
-            <v-icon>mdi-dots-vertical</v-icon>
+            <v-icon aria-label="Aktionen für die Aufgabe" role="img" aria-hidden="false">mdi-dots-vertical</v-icon>
           </v-btn>
         </template>
         <v-list>
diff --git a/digiwf-apps/packages/apps/digiwf-tasklist/src/components/task/TaskFollowUpDialog.vue b/digiwf-apps/packages/apps/digiwf-tasklist/src/components/task/TaskFollowUpDialog.vue
index c52b0689dd..43386558e8 100644
--- a/digiwf-apps/packages/apps/digiwf-tasklist/src/components/task/TaskFollowUpDialog.vue
+++ b/digiwf-apps/packages/apps/digiwf-tasklist/src/components/task/TaskFollowUpDialog.vue
@@ -37,6 +37,7 @@
             />
           </template>
           <v-date-picker
+            role="menuitem"
             v-model="dateSelection"
             locale="de-de"
             @input="dateSelectionOpen = false"
diff --git a/digiwf-apps/packages/apps/digiwf-tasklist/src/components/task/TaskItem.vue b/digiwf-apps/packages/apps/digiwf-tasklist/src/components/task/TaskItem.vue
index 7d8895adad..03f3907577 100644
--- a/digiwf-apps/packages/apps/digiwf-tasklist/src/components/task/TaskItem.vue
+++ b/digiwf-apps/packages/apps/digiwf-tasklist/src/components/task/TaskItem.vue
@@ -75,8 +75,10 @@
             v-bind="attrs"
             @click="(event) => { event.preventDefault()}"
             v-on.prevent="on"
+            aria-label="Aktionen für die Aufgabe"
+            aria-hidden="false"
           >
-            <v-icon>mdi-dots-vertical</v-icon>
+            <v-icon aria-label="Aktionen für die Aufgabe" role="img" aria-hidden="false">mdi-dots-vertical</v-icon>
           </v-btn>
         </template>
         <v-list>