Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support /* v8 ignore ... hints #215

Closed
AriPerkkio opened this issue Jun 15, 2023 · 2 comments · Fixed by #228
Closed

Support /* v8 ignore ... hints #215

AriPerkkio opened this issue Jun 15, 2023 · 2 comments · Fixed by #228

Comments

@AriPerkkio
Copy link
Contributor

This package is used by test runners which do not use c8:

It's confusing for end users to have to ignore code using /* c8 ignore next */ when these test runners have nothing to do with c8.

I would suggest to add support for /* v8 ignore ... */ syntax for ignore hints. The old /* c8 ignore ... */ should be preserved for backwards compatibility. I'm happy to implement this.

@AriPerkkio AriPerkkio changed the title Support /* v8 ignore ... hints Support /* v8 ignore ... hints Jun 15, 2023
@SimenB
Copy link
Member

SimenB commented Oct 5, 2023

Yeah, I think that's a good idea! Happy to take a PR to that effect

@SimenB
Copy link
Member

SimenB commented Nov 22, 2023

https://github.com/istanbuljs/v8-to-istanbul/releases/tag/v9.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants