Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build currently failing on master #95

Closed
bcoe opened this issue Dec 15, 2015 · 6 comments
Closed

build currently failing on master #95

bcoe opened this issue Dec 15, 2015 · 6 comments
Labels

Comments

@bcoe
Copy link
Member

bcoe commented Dec 15, 2015

All the branches merged were in the green, but it seems as though the combined build is failing on travis:

https://travis-ci.org/bcoe/nyc

@bcoe bcoe added the bug label Dec 15, 2015
@jamestalmage
Copy link
Member

Digging into it now

@bcoe
Copy link
Member Author

bcoe commented Dec 15, 2015

Cool, in the meantime, working on getting AppVeyor up and running for builds too 👍

@jamestalmage
Copy link
Member

Well, at least part of the reason is that I am an idiot.

I was using the old name and api capture-require vs, the new one append-transform. I'm not sure why that would make it fail on Travis though.

Also, I had capture-require installed as a dev-dependency. So that would certainly have caused problems (but not on travis I wouldn't think).

@bcoe
Copy link
Member Author

bcoe commented Dec 15, 2015

@jamestalmage that probably explains both problems -- it's been a busy few weeks for me, and I honestly just thought I'd dreamt the whole renaming thing ;)

@jamestalmage
Copy link
Member

Well,
Turns out it was me being an idiot, plus the presence of the Coveralls environment variable on Travis.
Apparently that forces tap into coverage mode, which meant we were double wrapping ourselves again, a --no-cov flag seems to have fixed it.

@bcoe
Copy link
Member Author

bcoe commented Dec 15, 2015

@jamestalmage I won't have you disparaging yourself! especially right before I'm going to try to convince you to get our tests running on Windows 😛

the nyc - travis - tap - nyc - sourcemap, etc., interaction is confusing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants