Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Option Plugins #948

Merged
merged 5 commits into from
Jan 26, 2019
Merged

feat: Option Plugins #948

merged 5 commits into from
Jan 26, 2019

Conversation

wzalazar
Copy link
Contributor

@wzalazar wzalazar commented Dec 7, 2018

This PR introduces:

The ability to add more plugins for @babel/parser to istanbuljs instrumenter

related poetapp/node#230 istanbuljs/istanbuljs#205

@wzalazar
Copy link
Contributor Author

The CI fails because I have problems with node version 6.15.1, the issue is with LAZY_LOAD_COUNT, if I change this line in local with node version 6.15.1 the command npm test is executed successfully

 // modules lazy-loaded when first file is instrumented.
-const LAZY_LOAD_COUNT = 266
+const LAZY_LOAD_COUNT = 269

I'm not sure how I can fix it, also I don't understand how my changes affect these tests

@JaKXz
Copy link
Member

JaKXz commented Jan 14, 2019

@wzalazar thank you for the contribution. Would you mind rebasing, I think we've made some changes recently that will better support this (in testing especially)

@wzalazar
Copy link
Contributor Author

@JaKXz ok, thanks!!! I will do ;)

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.389% when pulling e6b1b54 on wzalazar:plugins into 35cd49a on istanbuljs:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.389% when pulling e6b1b54 on wzalazar:plugins into 35cd49a on istanbuljs:master.

@wzalazar
Copy link
Contributor Author

wzalazar commented Jan 21, 2019

@JaKXz failed again, can you check out? I can't reload the task

@coreyfarrell
Copy link
Member

Looks like a travis-ci error installing node.js on Windows. I restarted the job.

@JaKXz JaKXz requested a review from bcoe January 22, 2019 04:15
@JaKXz
Copy link
Member

JaKXz commented Jan 22, 2019

I'll leave this to @coreyfarrell or @bcoe to merge!

@coreyfarrell coreyfarrell merged commit df2730d into istanbuljs:master Jan 26, 2019
@coreyfarrell
Copy link
Member

@wzalazar thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants