fix: Update caching-transform options. #873
Conversation
When updating caching--transform it was missed that the `hash` option has been refactored. This means that two files with identical contents would be treated as identical. Add a test to verify that two sources with identical contents are both instrumented.
|
|
||
| assert.equal(file1(), file2()) | ||
|
|
||
| const cov = (new Function('return this.__coverage__'))() |
There was a problem hiding this comment.
I'm open to better ways to test that the coverage data includes the 3 files.
There was a problem hiding this comment.
@coreyfarrell this assertion seems reasonable to me but, out of curiosity, what would the behavior have been before your fixes to the caching transform, would we have only had one of the two files listed in the coverage object?
mind testing running this test prior to your fix and confirming that it breaks as expected?
There was a problem hiding this comment.
I did test it, without the fixes to caching-transform this test would not record results for identical-file2.js. This is because both identical files have the same hash value so caching-transform gave the instrumented code from file1 to file2. This meant file2 recorded it's results to file1.
When updating caching--transform it was missed that the
hashoptionhas been refactored. This means that two files with identical contents
would be treated as identical.
Add a test to verify that two sources with identical contents are
both instrumented.