"all: true" ignores include flag

[jwalton]

Expected Behavior

With this config file:

{
    "require": ["babel-register"],
    "reporter": ["lcov", "text-summary"],
    "extension": [".jsx", "*.js"],
    "include": ["src/**"],
    "all": true,
    "sourceMap": false,
    "instrument": false
}

I would expect only files in the 'src' folder to be instrumented.

Observed Behavior

In my project, I see nyc run out of memory because it tries to instrument everything. If I add a console.log() to this line I see that webpack built files in /dist are being instrumented.

Forensic Information

Operating System: OS/X
Environment Information:
node: 8.9.4
nyc: 11.4.1
output: https://gist.github.com/jwalton/193c1fcd02ad861d8805047e193b93f0

[JSteitz]

Have the same problem

As a workaround you can do the following:

1. Exclude all directories except source

{
    "all": true,
    "exclude": [
        "test",
        "build",
        "coverage",
        "dist",
        etc..
    ]
}

2. Change the root path (Currently I'm using this method)

{
    "all": true,
    "cwd": "./source"
}

[bcoe]

@jwalton @JSteitz this definitely feels like a bug to me. Will happily accept a patch if either of you have a chance to dig into the issue before me.

[peterjgrainger]

I'm happy to pick this up.

Would the change be here: https://github.com/istanbuljs/nyc/blob/master/index.js#L179

The change would be to use the includes list if defined. If it isn't then use this.cmd?

[coreyfarrell]

I believe this will be fixed by #914?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.