Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement --all without requiring modules #183

Closed
novemberborn opened this issue Mar 6, 2016 · 1 comment · Fixed by #286
Closed

Implement --all without requiring modules #183

novemberborn opened this issue Mar 6, 2016 · 1 comment · Fixed by #286

Comments

@novemberborn
Copy link
Contributor

Currently when --all is used we require all modules that match a glob pattern. This causes these files to be instrumented and a baseline coverage to be established in the main process.

Requiring all modules has a few problems:

Instead what we should do:

  1. Get a list of modules matching the glob pattern, without requiring them
  2. Run the subprocesses
  3. Built the coverage report for the subprocesses
  4. For all modules found in step 1, that are not in the coverage report, synthesize coverage reports directly in nyc without instrumenting the files. We can generate these for the actual source and no transpiling should be necessary

Once we do this we may even be able to remove the --require flag, shifting transpilation responsibilities to the subprocess.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants