Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Script for automatically "smoke testing" against a set of libraries, looking for regressions. #116

Closed
jamestalmage opened this issue Dec 26, 2015 · 7 comments

Comments

@jamestalmage
Copy link
Member

#108 (comment)

I think this could be an awesome general purpose module. My thoughts:

  • It needs a simple config file that lists the projects that depend on the one you want to "smoke test".
  • Mimic .travis.yml for configuring scripts (just the script names from the travis Build Lifecyle, not all their config options).
  • The config file would need to point to the repository and branch to clone.
  • The module would clone each individual downstream dependent in a temp directory and run the scripts described above, npm linking the module under test.
  • If there are any failures, it will open the temp folder in your Finder/File Explorer, and list the failing dependents (maybe deleting the folders of passing dependents).

Folder structure:

some/temp/dir/
   downstream-dependent-1/
     ...
   downstream-dependent-2/
     ...

// @bcoe @novemberborn

I think we have a need for something like this for AVA as well.

// @sindresorhus @vdemedes

@sindresorhus
Copy link
Member

👍 We should definitely have this for AVA. I currently do it manually once in awhile and before a release.

Prior art: https://github.com/bahmutov/dont-break // @bahmutov

@jamestalmage
Copy link
Member Author

Cool. Let's try using that and see how it goes.

@bahmutov
Copy link

I will be happy to help

@bcoe
Copy link
Member

bcoe commented Dec 29, 2015

@jamestalmage I like this idea, and I could see it being a useful hosted service like travis 👍

I've only thought about it a bit, but some things I'd like to be able to do:

  • run another test-suite with an arbitrary library linked in against it (the library you're testing).
  • it would be nice to be able to assert to CLI output.
  • it would be nice to be able to assert that a file exists, and that it has certain content in it.
  • it would be nice to be able to assert that an HTML, JSON, or XML file has specific fields.

@jamestalmage
Copy link
Member Author

@bcoe - instead of building all that in, what if the config file just added a validate field that pointed to a script that was passed the output directory of the automated run?

@stale stale bot added the wontfix label Jan 6, 2019
@stale stale bot added the stale label Mar 7, 2019
@istanbuljs istanbuljs deleted a comment from stale bot Mar 7, 2019
@istanbuljs istanbuljs deleted a comment from stale bot Mar 7, 2019
@coreyfarrell
Copy link
Member

I'm cleaning up some old issues. I think this is a good idea, but I feel like this is outside the scope of nyc. Maybe this belongs in https://github.com/nodejs/tooling/issues instead? Could we leverage dont-break for this (either as a dependency or by contributing required features to dont-break)?

@stale
Copy link

stale bot commented May 6, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants