fix(cli): Report error if unwanted positional arguments are received #1100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaKXz
approved these changes
May 9, 2019
coreyfarrell
force-pushed
the
stricter-yargs
branch
from
fc2a5b5
to
c509e64
Compare
coreyfarrell
changed the title
This applies to check-coverage, instrument, merge and report. Passing additional arguments will now cause the help script to be displayed and an error exit code. Unknown flags `nyc report --unknown=1` are still not reported. Reporting unknown flags would require additional work as `yargs.strict()` causes unknown items from configuration to be reported, including flags that are defined for the global command but not a sub-command. Fixes istanbuljs#401
coreyfarrell
force-pushed
the
stricter-yargs
branch
from
c509e64
to
364c742
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This applies to check-coverage, instrument, merge and report. Passing
additional arguments will now cause the help script to be displayed and
an error exit code.
Unknown flags
nyc report --unknown=1are still not reported.Reporting unknown flags would require additional work as
yargs.strict()causes unknown items from configuration to be reported,including flags that are defined for the global command but not a
sub-command.
Fixes #401
Is this a breaking change? I lean towards no but can see the argument. Likely this will first be released to 15.0.0 anyways but I'm not sure if it should be noted under breaking changes in the changelog.