fix: set processinfo pid/ppid to actual numbers #1057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreyfarrell
approved these changes
Apr 5, 2019
|
Note for when this merges: We should tag the squashed commit as a |
isaacs
force-pushed
the
processinfo-numeric-pid
branch
from
1ac247f
to
f35ec14
Compare
As of Node.js v6, process.ppid is available, and a number. So, there's no need to pass the parent PID through the environment, which casts it to a string. BREAKING CHANGE: this changes the data type of the pid/ppid fields in processinfo files
isaacs
force-pushed
the
processinfo-numeric-pid
branch
from
f35ec14
to
32e2a10
Compare
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of Node.js v6, process.ppid is available, and a number. So, there's
no need to pass the parent PID through the environment, which casts it
to a string.