Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Allow adding CSS classes to generated HTML elements #1003

Open
3 tasks done
gflohr opened this issue Mar 26, 2024 · 1 comment
Open
3 tasks done

Feature request: Allow adding CSS classes to generated HTML elements #1003

gflohr opened this issue Mar 26, 2024 · 1 comment
Labels
client (Javascript) client code and CSS feature
Milestone

Comments

@gflohr
Copy link

gflohr commented Mar 26, 2024

Checklist

What is not working?

I want to style elements not with the class names that isso provides but my own ones. For example, I want the submit button to have the classes "btn btn-primary". That way, I can use a CSS framework, for example Bootstrap which defines tons of rules for these classes, so that just copying the CSS is not really an option.

Several ideas how this could be implemented:

  • use a template for the generated HTML
  • fire an event after the comments section has been rendered, so that the DOM can be manipulated
  • allow adding class names to the generated HTML elements
@ix5
Copy link
Member

ix5 commented May 22, 2024

Might be possible to implement this using the data-isso-* attributes similar to translation overrides.

Features like this (especially hooking into some event handler) would require a re-thinking of how the client currently works. Feel free to propose a better extension/hooking mechanism than the current state.

See also #894

@ix5 ix5 added client (Javascript) client code and CSS feature labels May 22, 2024
@ix5 ix5 added this to the 0.14 milestone May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client (Javascript) client code and CSS feature
Projects
None yet
Development

No branches or pull requests

2 participants