Implement "use constructor" code action #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pepeiborra
approved these changes
Feb 28, 2021
pepeiborra
reviewed
Feb 28, 2021
plugins/hls-tactics-plugin/src/Ide/Plugin/Tactic/LanguageServer/TacticProviders.hs
Outdated
Show resolved
Hide resolved
|
Does this currently do any type checking on the suggested constructors? e.g. if the type indices that the constructor uses will match up with the required type. Is it possible to easily do? |
|
@pepeiborra implemented configurable option. PTAL |
|
@googleson78 oh, I didn't even think of that. Great idea. I'll implement it here. |
pepeiborra
reviewed
Feb 28, 2021
|
@googleson78 done. Mind checking the tests in 3d79859 and making sure you agree with them? |
|
They seem ok. Nice that other tactics machinery can be reused here! |
Missing features were accidentally blocking all code actions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
Use constructor <x>code action. It only runs on data types with small numbers of constructors (notHsExpr) in order to not spam the code action list.Fixes isovector#21
Subsumes #521