Ensure that a created secret is available as a concrete type #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plumdog
reviewed
Feb 28, 2020
| throw new Error("Cannot set both secret and secretName") | ||
| } else if(props.secret) { | ||
| this.secretArn = props.secret.secretArn; | ||
| this.secret = undefined; |
There was a problem hiding this comment.
This line feels really weird, but I think I'm persuaded that it makes sense.
If you've passed in the Secret or ISecret, then you don't need it returned back to you, I guess.
plumdog
approved these changes
Feb 28, 2020
plumdog
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We just return whatever we were given, or what we've got. It is up to the user to know what they provided.
This works, I can tag secrets created by this resource.