Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Base64 encoding in the frontend #360

Open
alexanderleegs opened this issue Mar 1, 2021 · 1 comment
Open

Base64 encoding in the frontend #360

alexanderleegs opened this issue Mar 1, 2021 · 1 comment
Labels
P3 Good to have, do it when P1 and P2 are done

Comments

@alexanderleegs
Copy link
Contributor

Currently, our handling of encoding is inconsistent - some functions handle the encoding while others do not. Moving forward, we should standardise this behaviour by having the backend be in charge of base64 encoding/decoding. This also means any YAML needs to be loaded and sent as a JSON response.
@alexanderleegs alexanderleegs added the P3 Good to have, do it when P1 and P2 are done label Mar 1, 2021
@kwajiehao
Copy link
Contributor

Partially completed with PR #380 and PR #133 on the backend.

The remaining parts of the frontend codebase which handles base64 encoding and decoding will be cleaned up in a subsequent PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P3 Good to have, do it when P1 and P2 are done
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexanderleegs @kwajiehao