Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error-handling: toast notifications #279

Closed
kwajiehao opened this issue Dec 2, 2020 · 1 comment · Fixed by #281
Closed

Error-handling: toast notifications #279

kwajiehao opened this issue Dec 2, 2020 · 1 comment · Fixed by #281
Assignees
@kwajiehao
Labels
P1 Do it now.

Comments

@kwajiehao
Copy link
Contributor

Previously, issue #253 brought up the need for toast notifications when our API calls fail. Toast notifications are crucial for conveying feedback to users when something goes wrong, and also to provide them with some information on how to proceed.

We should implement a toast notification for each failed API call in the frontend.
@kwajiehao kwajiehao added the P1 Do it now. label Dec 2, 2020
@kwajiehao kwajiehao self-assigned this Dec 2, 2020
@kwajiehao kwajiehao mentioned this issue Dec 3, 2020
Merged
@kwajiehao kwajiehao linked a pull request Dec 7, 2020 that will close this issue
Feat/toast notification errors #281
Merged
@kwajiehao
Copy link
Contributor Author

Resolved with #281

@kwajiehao kwajiehao mentioned this issue Dec 8, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kwajiehao kwajiehao

Labels
P1 Do it now.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feat/toast notification errors isomerpages/isomercms-frontend
1 participant
@kwajiehao