Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error handling for event handlers, async code, etc. #263

Closed
kwajiehao opened this issue Nov 25, 2020 · 1 comment
Closed

Error handling for event handlers, async code, etc. #263

kwajiehao opened this issue Nov 25, 2020 · 1 comment
Labels
P2 Important, but not urgent. Do it when have time.

Comments

@kwajiehao
Copy link
Contributor

Currently, we use error boundaries to deal with errors in rendering or React lifecycle methods. However, error boundaries do not deal with the following errors (reference: https://reactjs.org/docs/error-boundaries.html#introducing-error-boundaries):

  • Event handlers
  • Asynchronous code (e.g. setTimeout or requestAnimationFrame callbacks)
  • Server side rendering
  • Errors thrown in the error boundary itself (rather than its children)

For that, we might consider using the react-error-boundary library (https://github.com/bvaughn/react-error-boundary)
@kwajiehao kwajiehao added the P2 Important, but not urgent. Do it when have time. label Nov 25, 2020
@kwajiehao kwajiehao mentioned this issue Nov 25, 2020
Merged
@kwajiehao
Copy link
Contributor Author

Fixed with #262, #280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
P2 Important, but not urgent. Do it when have time.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kwajiehao