-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(permalinks): default permalink for create #1843
fix(permalinks): default permalink for create #1843
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @kishore03109 and the rest of your teammates on Graphite |
d036802
to
c96bc10
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocking on regex
c96bc10
to
3f3f0ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for resource pages, do they also use this pageSettingsModal
? otherwise, we might also need to duplicate the changes here over.
## Problem same as #1843 but for resource pages ## Tests follow video https://github.com/isomerpages/isomercms-frontend/assets/42832651/f545f927-90ba-4daf-a555-62f5b1a834f7 - [ ] create a resource page, note that you should be unable to modify the permalink - [ ] edit resource page modal's functionality remains the same, we dont still allow them to change to whatever.
Problem
We have quite a number of duplicate permalinks
this does not fix the problem completely, but it does allow for some sort of preventive measure to prevents accidental dups.
we are not sure if of the number of agencies that use dup permalinks for the sake of playground, and it would be hard to enforce this until we have the functionality for playground out. more context here
Solution
sane default when creating a page.
Breaking Changes
Tests
follow video
Screen.Recording.2024-03-14.at.3.15.06.PM.mov