Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/feature-flag-link-checker #1811

Merged
merged 2 commits into from
Feb 22, 2024
Merged

feat/feature-flag-link-checker #1811

merged 2 commits into from
Feb 22, 2024

Conversation

kishore03109
Copy link
Contributor

@kishore03109 kishore03109 commented Feb 22, 2024 •
edited
Loading

Problem

Adding feature flag to throttle rollout of broken link checker to production.

Solution

Breaking Changes

  • Yes - this PR contains breaking changes
    • Details ...
  • No - this PR is backwards compatible with ALL of the following feature flags in this doc

Tests

  • When accessing /sites/<your-site-name>/linkCheckerReport on staging, it should result in a redirect back to the dashboard.
    IMPORTANT so as to not trip off alarms
  • When feature flag is off, no network calls should be made to getLinkCheckerStatus in the backend

@kishore03109 Graphite App
Copy link
Contributor Author

kishore03109 commented Feb 22, 2024 •
edited
Loading

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@kishore03109 kishore03109 mentioned this pull request Feb 22, 2024
Merged
6 tasks
@kishore03109 kishore03109 marked this pull request as ready for review February 22, 2024 04:13
@kishore03109 kishore03109 requested a review from a team February 22, 2024 04:13
@kishore03109 kishore03109 force-pushed the 02-22-feat/addBrokenLinksReporter branch from 66882da to cc966fa Compare February 22, 2024 04:26
alexanderleegs
alexanderleegs approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@alexanderleegs alexanderleegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only reviewing second commit: lgtm

src/layouts/SiteDashboard/SiteDashboard.tsx Outdated Show resolved Hide resolved
@kishore03109 kishore03109 force-pushed the 02-22-feat/feature-flag-link-checker branch from 1c2abc9 to d0a6ce8 Compare February 22, 2024 05:11
@kishore03109 kishore03109 force-pushed the 02-22-feat/feature-flag-link-checker branch from 2578d9a to 8c4ae88 Compare February 22, 2024 06:57
@kishore03109 Graphite App
Copy link
Contributor Author

kishore03109 commented Feb 22, 2024 •
edited
Loading

Merge activity

  • Feb 22, 3:03 AM EST: @kishore03109 started a stack merge that includes this pull request via Graphite.
  • Feb 22, 3:05 AM EST: Graphite rebased this pull request as part of a merge.

@kishore03109 kishore03109 changed the base branch from 02-22-feat/addBrokenLinksReporter to develop February 22, 2024 08:03
@kishore03109 kishore03109 force-pushed the 02-22-feat/feature-flag-link-checker branch from 8c4ae88 to 5ca9079 Compare February 22, 2024 08:04
@kishore03109 kishore03109 merged commit 5a54c27 into develop Feb 22, 2024
6 checks passed
@mergify mergify bot deleted the 02-22-feat/feature-flag-link-checker branch February 22, 2024 08:07
@alexanderleegs alexanderleegs mentioned this pull request Feb 22, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderleegs alexanderleegs alexanderleegs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kishore03109 @alexanderleegs