fix(scss): importing of styles #1653
Conversation
kishore03109
force-pushed
the
IS-631-Button-text-in-hero-banner-lacks-contrast
branch
from
20a5b4c to
cd82126
Compare
| @@ -63,7 +63,7 @@ const createPageStyleSheet = (repoName, primaryColor, secondaryColor) => { | |||
|
|
|||
| // EditHomepage: hero button - secondary color | |||
| customStyleSheet.insertRule( | |||
| `.is-secondary { background-color: ${secondaryColor} !important;}`, | |||
| `.is-secondary { background-color: ${secondaryColor} !important; color: #fff !important;}`, | |||
There was a problem hiding this comment.
can i check where you got this from?
There was a problem hiding this comment.
hmm am worried about regression too, got it from this line here. is this sound?
There was a problem hiding this comment.
We should check the scss file itself to see the condition.
This also requires an additional class bp-button so the conditions aren't exactly the same
There was a problem hiding this comment.
to be clear thats from the live site, the one in our preview is here!
|
This pull request has been stale for more than 30 days! Could someone please take a look at it @isomerpages/iso-engineers |
2 similar comments
|
This pull request has been stale for more than 30 days! Could someone please take a look at it @isomerpages/iso-engineers |
|
This pull request has been stale for more than 30 days! Could someone please take a look at it @isomerpages/iso-engineers |
mergify
bot
deleted the
IS-631-Button-text-in-hero-banner-lacks-contrast
branch
Problem
Text colors are the same for preview + staging sites
is-Secondary change is abit scary, after doing a string search on
.is-secondarynoted that this is used for.bp-button.bp-secinputtextareaselectfilehelpbp-notificationnavbarbp-heronav bar + incols was ok
the search bar in the staging site looked alright + the files not used in blueprint.scss
For reference, in
blueprint.scsshas the following rules:Testing plan