refactor(hero): duplicate changes from template #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seaerchin
force-pushed
the
fix/template-hero-changes
branch
from
7faaee1 to
114af6a
Compare
kishore03109
reviewed
Oct 3, 2023
|
@kishore03109 - downstream PR here fixes; this PR merges into the same basen (ps, should've made clear in PR description) |
kishore03109
approved these changes
Oct 3, 2023
seaerchin
force-pushed
the
chore/hero-template
branch
from
a6371ed to
c0e0f5b
Compare
seaerchin
force-pushed
the
fix/template-hero-changes
branch
from
7b5a3d4 to
3d72618
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: build fails but is fixed here
Problem
dup of this to frontend
Solution
copy paste styling etc to frontend