Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(hero): duplicate template changes #1547

Merged
merged 4 commits into from
Oct 3, 2023
Merged

chore(hero): duplicate template changes #1547

merged 4 commits into from
Oct 3, 2023

Conversation

seaerchin
Copy link
Contributor

@seaerchin seaerchin commented Oct 2, 2023 •
edited
Loading

Note: failing build is due to missing imports - fixed in followup

Problem

Duplicate of template PR to frontend.

Solution

  1. change representation of width from x% to sm/md to allow for styles injection using css classes
  2. new style for floating variant for 769 - 1023
  3. side variant new design on super big width
  4. misc style changes

@seaerchin seaerchin requested a review from a team October 2, 2023 04:50
alexanderleegs
alexanderleegs previously requested changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@alexanderleegs alexanderleegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build is failing because of @use 'templates/components/hero.scss'; in isomer-template.scss and ./src/styles/isomer-cms/pages/Editor.module.scss

@seaerchin
Copy link
Contributor Author

@alexanderleegs - downstream PR here fixes

@seaerchin seaerchin requested review from alexanderleegs and a team October 3, 2023 02:51
@seaerchin seaerchin dismissed alexanderleegs’s stale review October 3, 2023 03:07

stale - downstream fixes

alexanderleegs
alexanderleegs approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@alexanderleegs alexanderleegs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops forgot i alr reviewed the downstream

@seaerchin seaerchin force-pushed the chore/hero-template branch from a6371ed to c0e0f5b Compare October 3, 2023 03:36
@seaerchin seaerchin merged commit ec77e97 into develop Oct 3, 2023
3 checks passed
@seaerchin seaerchin deleted the chore/hero-template branch October 3, 2023 03:36
@seaerchin seaerchin mentioned this pull request Oct 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcshzj dcshzj dcshzj approved these changes

@alexanderleegs alexanderleegs alexanderleegs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seaerchin @alexanderleegs @dcshzj