From 9df4f1e7280132dc08f363eb9086d15477619be6 Mon Sep 17 00:00:00 2001 From: kwajiehao Date: Mon, 7 Jun 2021 17:39:40 +0800 Subject: [PATCH] fix: prevent eslint errors from blocking build Currently, when we attempt to start our react app, create-react-app fails to compile when there are any eslint or prettier errors. The reason for this is documented in this github issue: https://github.com/facebook/create-react-app/issues/9887#issuecomment-720902192 This issue is fixed with react-scripts v4.0.2 with the use of an ESLINT_NO_DEV_ERRORS env var (this is documented under advanced configuration here: https://create-react-app.dev/docs/advanced-configuration/) This commit adds the ESLINT_NO_DEV_ERRORS env var to our env-example file. We will need to separately add it to our production and staging environments too. --- .env-example | 1 + 1 file changed, 1 insertion(+) diff --git a/.env-example b/.env-example index 00c027f27..41840176f 100644 --- a/.env-example +++ b/.env-example @@ -3,6 +3,7 @@ export REACT_APP_BACKEND_URL='' export REACT_APP_SENTRY_ENV='' export REACT_APP_SENTRY_DSN='' export REACT_APP_ENV='LOCAL_DEV' +export ESLINT_NO_DEV_ERRORS=true # Cypress test environment variables export CYPRESS_BASEURL=''