From 5c6893abb977e376f3defc9729b35b77bc1bafd6 Mon Sep 17 00:00:00 2001
From: Harish V <harish@open.gov.sg>
Date: Tue, 21 Mar 2023 14:11:22 +0800
Subject: [PATCH] fix: make default empty strings

---
 src/config/config.ts | 38 +++++++++++++++++++-------------------
 1 file changed, 19 insertions(+), 19 deletions(-)

diff --git a/src/config/config.ts b/src/config/config.ts
index 7dd38aad4..e27c55641 100644
--- a/src/config/config.ts
+++ b/src/config/config.ts
@@ -59,14 +59,14 @@ const config = convict({
     env: "CLOUDMERSIVE_API_KEY",
     sensitive: true,
     format: "required-string",
-    default: null,
+    default: "",
   },
   app: {
     frontendUrl: {
       doc: "URL of the frontend application",
       env: "FRONTEND_URL",
       format: "required-string",
-      default: null,
+      default: "",
     },
   },
   mutexTableName: {
@@ -87,7 +87,7 @@ const config = convict({
       env: "LOCAL_SITE_ACCESS_TOKEN",
       sensitive: true,
       format: "required-string",
-      default: null,
+      default: "",
     },
   },
   auth: {
@@ -108,14 +108,14 @@ const config = convict({
       env: "JWT_SECRET",
       sensitive: true,
       format: "required-string",
-      default: null,
+      default: "",
     },
     encryptionSecret: {
       doc: "Secret used to encrypt access GitHub access token",
       env: "ENCRYPTION_SECRET",
       sensitive: true,
       format: "required-string",
-      default: null,
+      default: "",
     },
     maxNumOtpAttempts: {
       doc: "Maximum number of OTP attempts allowed",
@@ -157,21 +157,21 @@ const config = convict({
         env: "AWS_ACCOUNT_NUMBER",
         sensitive: true,
         format: "required-string",
-        default: null,
+        default: "",
       },
       accessKeyId: {
         doc: "AWS access key ID",
         env: "AWS_ACCESS_KEY_ID",
         sensitive: true,
         format: "required-string",
-        default: null,
+        default: "",
       },
       secretAccessKey: {
         doc: "AWS secret access key",
         env: "AWS_SECRET_ACCESS_KEY",
         sensitive: true,
         format: "required-string",
-        default: null,
+        default: "",
       },
     },
     sqs: {
@@ -179,19 +179,19 @@ const config = convict({
         doc: "URL of the incoming SQS queue",
         env: "INCOMING_QUEUE_URL",
         format: "required-string",
-        default: null,
+        default: "",
       },
       outgoingQueueUrl: {
         doc: "URL of the outgoing SQS queue",
         env: "OUTGOING_QUEUE_URL",
         format: "required-string",
-        default: null,
+        default: "",
       },
       siteLaunchQueueUrl: {
         doc: "URL of the site launch SQS queue",
         env: "SITE_LAUNCH_QUEUE_URL",
         format: "required-string",
-        default: null,
+        default: "",
       },
     },
   },
@@ -218,20 +218,20 @@ const config = convict({
       doc: "GitHub OAuth app Client ID",
       env: "CLIENT_ID",
       format: "required-string",
-      default: null,
+      default: "",
     },
     clientSecret: {
       doc: "GitHub OAuth app Client secret",
       env: "CLIENT_SECRET",
       sensitive: true,
       format: "required-string",
-      default: null,
+      default: "",
     },
     redirectUri: {
       doc: "URL to redirect to after authentication with GitHub",
       env: "REDIRECT_URI",
       format: "required-string",
-      default: null,
+      default: "",
     },
     branchRef: {
       doc: "Git branch to use for saving modifications to site",
@@ -244,7 +244,7 @@ const config = convict({
       env: "SYSTEM_GITHUB_TOKEN",
       sensitive: true,
       format: "required-string",
-      default: null,
+      default: "",
     },
   },
   dataDog: {
@@ -258,13 +258,13 @@ const config = convict({
       doc: "The DataDog service",
       env: "DD_SERVICE",
       format: "required-string",
-      default: null,
+      default: "",
     },
     tags: {
       doc: "The DataDog tags",
       env: "DD_TAGS",
       format: "required-string",
-      default: null,
+      default: "",
     },
   },
   formSg: {
@@ -303,7 +303,7 @@ const config = convict({
       env: "E2E_TEST_SECRET",
       sensitive: true,
       format: "required-string",
-      default: null,
+      default: "",
     },
     e2eTestGithubToken: {
       doc:
@@ -311,7 +311,7 @@ const config = convict({
       env: "E2E_TEST_GH_TOKEN",
       sensitive: true,
       format: "required-string",
-      default: null,
+      default: "",
     },
   },
   database: {