From 48768e18f9927ff77021adf439b7ffaa217b65f8 Mon Sep 17 00:00:00 2001
From: Alexander Lee <alexander@open.gov.sg>
Date: Thu, 7 Mar 2024 14:55:35 +0800
Subject: [PATCH] Feat/add back repair form lock (#1179)

* Revert "Revert "Chore/lock repos when repairing (#1149)""

This reverts commit a7462884ba9f1d072d1a1bac97e5d4c25d338adf.

* fix: return 200 to forms and adjust lock time

* chore: revert to 15 minutes

Tested with repos - they are able to lock/unlock independently so no need for scaling lock time
---
 src/routes/formsg/formsgGGsRepair.ts | 27 ++++++++++++++++++++++++---
 src/utils/mutex-utils.js             |  8 ++++----
 2 files changed, 28 insertions(+), 7 deletions(-)

diff --git a/src/routes/formsg/formsgGGsRepair.ts b/src/routes/formsg/formsgGGsRepair.ts
index 869902145..cf3eafd74 100644
--- a/src/routes/formsg/formsgGGsRepair.ts
+++ b/src/routes/formsg/formsgGGsRepair.ts
@@ -10,9 +10,15 @@ import { ResultAsync, errAsync, fromPromise, okAsync } from "neverthrow"
 
 import { config } from "@config/config"
 
-import { EFS_VOL_PATH_STAGING_LITE } from "@root/constants"
+import { lock, unlock } from "@utils/mutex-utils"
+
+import {
+  EFS_VOL_PATH_STAGING,
+  EFS_VOL_PATH_STAGING_LITE,
+} from "@root/constants"
 import GitFileSystemError from "@root/errors/GitFileSystemError"
 import InitializationError from "@root/errors/InitializationError"
+import LockedError from "@root/errors/LockedError"
 import { consoleLogger } from "@root/logger/console.logger"
 import logger from "@root/logger/logger"
 import { attachFormSGHandler } from "@root/middleware"
@@ -107,19 +113,25 @@ export class FormsgGGsRepairRouter {
       logger.error("Requester email is not from @open.gov.sg")
       return
     }
+    res.sendStatus(200) // we have received the form and obtained relevant field
     this.handleGGsFormSubmission(repoNames, requesterEmail)
   }
 
   handleGGsFormSubmission = (repoNames: string[], requesterEmail: string) => {
-    const repairs: ResultAsync<string, GitFileSystemError>[] = []
+    const repairs: ResultAsync<string, GitFileSystemError | LockedError>[] = []
 
     const clonedStagingRepos: string[] = []
     const syncedStagingAndStagingLiteRepos: string[] = []
+    const LOCK_TIME_SECONDS = 15 * 60 // 15 minutes
     repoNames.forEach((repoName) => {
       const repoUrl = `git@github.com:isomerpages/${repoName}.git`
 
       repairs.push(
-        this.doesRepoNeedClone(repoName)
+        ResultAsync.fromPromise(
+          lock(repoName, LOCK_TIME_SECONDS),
+          (err) => new LockedError(`Unable to lock repo ${repoName}`)
+        )
+          .andThen(() => this.doesRepoNeedClone(repoName))
           .andThen(() => {
             const isStaging = true
             return (
@@ -162,6 +174,15 @@ export class FormsgGGsRepairRouter {
                 return okAsync(result)
               })
           )
+          .andThen((result) => {
+            // Failure to unlock is not blocking
+            ResultAsync.fromPromise(unlock(repoName), () => {
+              logger.error(
+                "Failed to unlock repo - repo will unlock after at most 15 min"
+              )
+            })
+            return okAsync(result)
+          })
       )
     })
 
diff --git a/src/utils/mutex-utils.js b/src/utils/mutex-utils.js
index fa623c383..b0f19805b 100644
--- a/src/utils/mutex-utils.js
+++ b/src/utils/mutex-utils.js
@@ -35,10 +35,10 @@ const mockUnlock = (siteName) => {
   mockMutexObj[siteName] = false
 }
 
-const lock = async (siteName) => {
+const lock = async (siteName, lockLengthSeconds = 60) => {
   try {
-    const ONE_MIN_FROM_CURR_DATE_IN_SECONDS_FROM_EPOCH_TIME =
-      Math.floor(new Date().valueOf() / 1000) + 60
+    const expiryTime =
+      Math.floor(new Date().valueOf() / 1000) + lockLengthSeconds
 
     if (isE2eTestRepo(siteName)) return
     if (!IS_DEV) {
@@ -46,7 +46,7 @@ const lock = async (siteName) => {
         TableName: MUTEX_TABLE_NAME,
         Item: {
           repo_id: siteName,
-          expdate: ONE_MIN_FROM_CURR_DATE_IN_SECONDS_FROM_EPOCH_TIME,
+          expdate: expiryTime,
         },
         ConditionExpression: "attribute_not_exists(repo_id)",
       }