From 3512635125d8c70c67be229f30f45c96639b4fad Mon Sep 17 00:00:00 2001
From: Isidoro <61100499+isidorogu@users.noreply.github.com>
Date: Mon, 19 Feb 2024 17:54:38 -0500
Subject: [PATCH] Fixing notes from testing

---
 R/impact_eval.R  |  7 +++++++
 cran-comments.md | 13 +++++++------
 inst/CITATION    |  2 +-
 3 files changed, 15 insertions(+), 7 deletions(-)

diff --git a/R/impact_eval.R b/R/impact_eval.R
index 08694ac..04287a7 100644
--- a/R/impact_eval.R
+++ b/R/impact_eval.R
@@ -35,6 +35,13 @@ impact_eval <- function(data, endogenous_vars, treatment,
                          fixed_effect_vars = NULL, control_vars, cluster_var) {
   
   # Defining type of standard errors based & cluster_arg on the presence of cluster vars 
+  outcome<-NULL
+  term<-NULL
+  estimate<-NULL
+  p.value<-NULL
+  std.error<-NULL
+  statistic<-NULL
+  
   if (missing(cluster_var)) {
     se_type = "classical"
     clusters = NULL 
diff --git a/cran-comments.md b/cran-comments.md
index bcc86ad..26f896c 100644
--- a/cran-comments.md
+++ b/cran-comments.md
@@ -1,10 +1,11 @@
 ## Test environments
-* local MacOS install, R 4.0.0
-* x86_64-pc-linux-gnu (64 bit) (on travis-ci), R 4.0.0
-* Rhub Windows Server 2008 R2, R-devel (32/64) bit 
-* Win builder x86_64-w64-mingw32, Rdevel 
-
-
+* local MacOS install, R 4.3.2
+* mcaos 12.7.3 (R-release) on Github actions (GHA)
+* Microsoft Windows Server 2022 (R-release) on Github actions 
+* Microsoft Windows x86_64-w64-mingw32 R-devel from (Rhub)
+* ubuntu 22.04.03 (R-devel) on GHA 
+* ubuntu 22.04.03 (R-release) on GHA
+* ubuntu 22.04.03 (R-oldrel-1) on GHA
 
 ## R CMD check results
 There were no ERRORs, WARNINGs Nor  NOTEs.
diff --git a/inst/CITATION b/inst/CITATION
index 093c551..bcc9a83 100644
--- a/inst/CITATION
+++ b/inst/CITATION
@@ -2,7 +2,7 @@ citHeader("To cite RCT in publications use:")
 
 citEntry(entry = "Manual",
          title        = "Design and Evaluation of RCTs with {RCT}",
-         author       = personList(as.person("Isidoro Garcia-Urquieta")),
+         author       = c(as.person("Isidoro Garcia-Urquieta")),
          year         = "2020",
          url          = "https://github.com/isidorogu/RCT",