Modifying assertIs(x, False) to assertFalse(x) changes the meaning for falsey value of x

[Pierre-Sassoulas]

Hello, and thank you for your work on teyit.

In the following case:

-       self.assertIs(inferred.value, False)
+       self.assertFalse(inferred.value)

If inferred.value is equal to [] or {} for example, the code does not do what it was doing before. (The same problem also apply to assertIs(x, True) to assertTrue(x)

import unittest


class TeyitTest(unittest.TestCase):

    def test_teyit(self):
        self.assertFalse(False)
        self.assertFalse([])
        self.assertIs(False, False)
        self.assertIs([], False)

        self.assertFalse(False)
        self.assertFalse([])
        self.assertIs(False, False)
>       self.assertIs([], False)
E       AssertionError: [] is not False

Context: Trying to add teyit to astroid pre-commit in pylint-dev/astroid#1703

[isidentical]

Thanks for noticing this!

[nega0]

Any movement on this? With teyit being recommend in the Python 3.12 "What's New", it would be nice to see this addressed.