Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create benchmarks for ImmutableSet #14

Open
gabbard opened this issue Jan 24, 2019 · 5 comments
Open

Create benchmarks for ImmutableSet #14

gabbard opened this issue Jan 24, 2019 · 5 comments
Assignees

Comments

@gabbard
Copy link

gabbard commented Jan 24, 2019

These could probably be based on the Guava benchmarks: https://github.com/google/guava/tree/master/guava-tests/benchmark/com/google/common/collect

@gabbard
Copy link
Author

gabbard commented Jan 24, 2019

Quick things to try:

  1. (from @ConstantineLignos ) try using a dict with None values instead of a frozenset as backing
  2. Is it faster if we use a regular set instead of a frozenset as backing?

@gabbard
Copy link
Author

gabbard commented Jan 29, 2019

@nicomitchell : additional benchmarks to add:

  • item containment checks (both present and absent)
  • iteration
  • intersection, union, and difference
  • all of the above with empty sets

@gabbard
Copy link
Author

gabbard commented Jan 29, 2019

@ConstantineLignos : Please add any other requested benchmarks

@ConstantineLignos
Copy link
Contributor

Nothing to add right now, sounds like good coverage.

@nicomitchell
Copy link
Contributor

nicomitchell commented Feb 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants