Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LG 03-08 Should Include Dependency Injection explicitly #582

Closed
michaelpog opened this issue Oct 10, 2024 · 4 comments
Closed

LG 03-08 Should Include Dependency Injection explicitly #582

michaelpog opened this issue Oct 10, 2024 · 4 comments
Assignees
@sippsack @alxlo @gernotstarke @ulibecker @michaelpog
Labels
enhancement V2025 Release 2025

Comments

@michaelpog
Copy link

It appears that LG 03-08 explicitly mentions three patterns: Layer, Pipes and Filters and Microservices.
However, Dependency Injection is also indirectly mentioned as R1 in LG 03-06.
I think it would be better to mention Dependency Injection as one of the patterns in LG-08, explicitly.
Right now it's kind of buried in 03-06.
@gernotstarke gernotstarke added help wanted Extra attention is needed question Further information is requested labels Oct 10, 2024
@gernotstarke gernotstarke moved this to FLWG-Open / To Decide in V-2025 Oct 10, 2024
@gernotstarke
Copy link
Member

Right - D-Injection is mentioned in 03-06 as one option to achieve D-Inversion. In my opinion the cohesion between injection and inversion is higher, so I consider it better to put those two together in a single LG.

@rhoadesre
Copy link
Contributor

It wouldn't hurt to list it under 03-08 as well as 03-06. I agree with @michaelpog, it is "buried" in the 03-06 and not clear, if it is exam-relevant.

@gernotstarke gernotstarke added enhancement V2025 Release 2025 and removed help wanted Extra attention is needed question Further information is requested labels Oct 13, 2024
gernotstarke added a commit that referenced this issue Oct 13, 2024
@gernotstarke
#582 add dependency injection to LG-03-06 and cross-reference it
7269202
@gernotstarke
Copy link
Member

see PR #629

rhoadesre added a commit that referenced this issue Oct 13, 2024
@rhoadesre
Merge pull request #629 from isaqb-org/#582-relocate-dependency-injec…
e085aa3 
…tion

#582 add dependency injection to LG-03-06 and cross-reference it
@rhoadesre
Copy link
Contributor

Changes committed

@github-project-automation github-project-automation bot moved this from waiting-for-approval to Done / Implemented in V-2025 Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sippsack sippsack

@alxlo alxlo

@gernotstarke gernotstarke

@ulibecker ulibecker

@michaelpog michaelpog

Labels
enhancement V2025 Release 2025
Projects
V-2025
Status: Done / Implemented
Milestone
No milestone
Development

No branches or pull requests
6 participants
@sippsack @alxlo @gernotstarke @ulibecker @michaelpog @rhoadesre