Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting (orphaned) groups #210

Open
ghost opened this issue Feb 20, 2023 · 6 comments
Open

Deleting (orphaned) groups #210

ghost opened this issue Feb 20, 2023 · 6 comments

Comments

@ghost
Copy link

ghost commented Feb 20, 2023

I have quite a few groups that I once left via the signal android app, which are showing up in scli

Could there be an option, for example control + d, to delete them?

@exquo
Copy link
Collaborator

exquo commented Feb 22, 2023

Looks like #196 (which I have closed prematurely, apparently).

I've assumed that all of the linked devices (including signal-cli) receive the "group-deleted" events, and remove the groups on all of the devices. But after actually trying it, looks like that's not what happens..

If the groups are supposed to be deleted from each of the linked devices individually, then we do need a way to delete groups from scli as well. An alternative (proposed in #196) would be not to show "non-active" groups in scli at all; but there might be a message history that a user might want to see.

Deleting groups from scli would need changes upstream: AsamK/signal-cli#1192. After a group has already been quit on another device (e.g. the phone), it does not seem to be possible to delete such group from signal-cli.

@ghost
Copy link
Author

ghost commented Feb 24, 2023

i haven't tried deleting a group while having scli synced yet
But deleting a message remotely also doesn't work no matter on which device i do it

do i understand it right that scli is basically just a frontend for signal-cli?

@exquo
Copy link
Collaborator

exquo commented Feb 25, 2023

i haven't tried deleting a group while having scli synced yet

It would not show up in signal-cli: AsamK/signal-cli#1192

But deleting a message remotely also doesn't work no matter on which device i do it

I've just tested it: a message remote-deleted in signal-desktop shows up as [Deleted] in scli. Likewise, remote-deleting a msg from scli (with D) shows in signal-desktop as "This message was deleted". So, seems to work here.. If it doesn't work for you - feel free to open a new issue and to describe the details there.

do i understand it right that scli is basically just a frontend for signal-cli?

It would be more accurate to put it like "signal-cli is a backend for scli". In that, for scli it would be possible to replace signal-cli usage with something else, like signald, or one of signal-cli's own alternative interfaces (e.g. JSON-RPC). The bulk of scli is not hard-tied to signal-cli, although it's pretty tightly coupled, being the only backend to ever be used. But scli with a different backend would pretty much "remain itself". Writing another client around signal-cli from scratch would create a completely different app.

@ghost
Copy link
Author

ghost commented Feb 26, 2023

okay, I tested the message deleting and

a message written from my phone can be deleted on both devices via scli
it only gets deleted on the phone when remote deleted via the phone

a message written from scli doesnt get deleted on my phone via scli remote delete
also it cannot even be remote deleted from my phone (no option for that, only for self deletion)

Oh okay
Sadly don't really understand the code, as i really like the UI :)

@exquo
Copy link
Collaborator

exquo commented Mar 14, 2023

In the meantime (until AsamK/signal-cli#1192 is implemented), groups can be deleted manually from signal-cli (while scli is not running):

signal-cli quitGroup -g <GROUP_ID> --delete

To get groupIDs: signal-cli listGroups

@ghost
Copy link
Author

ghost commented Mar 21, 2023

that worked, thank you ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant