Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node-graceful-fs silently fails on windows #108

Closed
aeneasr opened this issue Feb 19, 2017 · 2 comments
Closed

node-graceful-fs silently fails on windows #108

aeneasr opened this issue Feb 19, 2017 · 2 comments

Comments

@aeneasr
Copy link

aeneasr commented Feb 19, 2017

This is an upstream issue of an upstream issue (node-fs-extra) of this original comment in electron-packager. That escalated quickly (see what I did there?) :D

electron-packager is a cli helper that packages an electron app. It does so by copying a node app (including node_modules) to the temp directory. This step uses fs.copy (from node-fs-extra) which silently fails.

In particular, apparently, at some point it simply stops without throwing an error, nor calling the callback:

fs.copy(opts.dir, appPath, {filter: ignore.userIgnoreFilter(opts), dereference: shouldDeref}, cb)

In node-fs-extra, I traced the issue back to this project, because I am 85% confident that the issue arises from calls like these do not result in a callback or quit unexpectedly.

I'd be glad to help you identify root cause of this issue. Note that this only happens on windows. On OSX, everything works fine.

@aeneasr aeneasr changed the title node-graceful silently fails on windows node-graceful-fs silently fails on windows Feb 19, 2017
@aeneasr
Copy link
Author

aeneasr commented Feb 20, 2017

The issue does apparently no longer occur on node 7.6.0

@coreyfarrell
Copy link
Collaborator

Since the last comment indicates this issue was resolved by a node.js update I'm closing. If the issue reappears please open a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants