Add pull_requests attribute to Story #139
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
read access is enough for my needs but I suppose we could extend the PullRequest class with methods to modify it |
|
Good PR and great add. Sorry we haven't gotten to this sooner - we've just taken ownership of this gem and are still getting ramped up. To make this PR complete, there would be some tests added that exercise reading the pull requests of a story. Do you mind adding some tests to the PR? |
In order to get it populated, `fields: 'pull_requests'` is required when calling the method that retrieves the story(ies) - otherwise it's nil
|
Code Climate has analyzed commit 1337312 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (50% is the threshold). This pull request will bring the total coverage in the repository to 97.5% (0.0% change). View more on Code Climate. |
irphilli
approved these changes
Apr 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to get it populated,
fields: 'pull_requests'is required whencalling the method that retrieves the story(ies) - otherwise it's nil